Re: cvs: php-src(PHP_5_2) /ext/mysql php_mysql.c
| From: | Felipe Pena | Date: | Tue, 12 Feb 2008 21:35:58 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_2) /ext/mysql php_mysql.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-48493@lists.php.net to get a copy of this message | ||
Em Ter, 2008-02-12 às 20:04 +0100, Hannes Magnusson escreveu:
> On Feb 12, 2008 11:24 AM, Felipe Pena <felipe@php.net> wrote:
> > felipe Tue Feb 12 10:24:35 2008 UTC
> >
> > Modified files: (Branch: PHP_5_2)
> > /php-src/ext/mysql php_mysql.c
> > Log:
> > MFB: Fixed Bug #44094 (SEGFAULT when using mysql_connect())
> >
> >
> > http://cvs.php.net/viewvc.cgi/php-src/ext/mysql/php_mysql.c?r1=1.213.2.6.2.20&r2=1.213.2.6.2.21&diff_format=u
> > Index: php-src/ext/mysql/php_mysql.c
> > diff -u php-src/ext/mysql/php_mysql.c:1.213.2.6.2.20
> > php-src/ext/mysql/php_mysql.c:1.213.2.6.2.21
> > --- php-src/ext/mysql/php_mysql.c:1.213.2.6.2.20 Sun Jan 20 14:13:11 2008
> > +++ php-src/ext/mysql/php_mysql.c Tue Feb 12 10:24:35 2008
> > @@ -18,7 +18,7 @@
> > +----------------------------------------------------------------------+
> > */
> >
> > -/* $Id: php_mysql.c,v 1.213.2.6.2.20 2008/01/20 14:13:11 bjori Exp $ */
> > +/* $Id: php_mysql.c,v 1.213.2.6.2.21 2008/02/12 10:24:35 felipe Exp $ */
> >
> > /* TODO:
> > *
> > @@ -556,7 +556,7 @@
> > hashed_details_length = spprintf(&hashed_details, 0,
> > "mysql__%s_", user);
> > client_flags = CLIENT_INTERACTIVE;
> > } else {
> > - if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC,
> > "|s!s!s!ll", &host_and_port, &host_len,
> > + if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC,
> > "|s!s!s!bl", &host_and_port, &host_len,
> > &user,
> > &user_len, &passwd, &passwd_len,
> > &new_link,
> > &client_flags)==FAILURE) {
> > return;
>
> Won't this break the client_flags parameter for mysql_pconnect()?
> (and you seem to have forgotten to add a NEWS entry for this fix)
>
> -Hannes
Ops, i meant 5_2_5. ;)
--
Regards,
Felipe Pena.