Re: cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h
| From: | Jani Taskinen | Date: | Fri, 15 Aug 2008 16:49:08 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-52389@lists.php.net to get a copy of this message | ||
You don't really need to comment about everything, do you?
Please get your facts correct first.
--Jani
Marcus Boerger [helly@php.net] kirjoitti:
Hello Jani, the real fix actually is to drop all #include config.h, because php needs to have php_config.h and not config.h as first file. marcus Friday, August 15, 2008, 6:37:24 PM, you wrote: Not enough info -> bogus. FYI: Just tested to be sure. Doing phpize build now fails. Works when reverted. (reverted btw..) I say again: Fix the REAL bugs, not symptoms of the real bugs.. --Jani Pierre Joye [pierre.php@gmail.com] kirjoitti:Best regards, Marcus -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.phpOn Fri, Aug 15, 2008 at 6:30 PM, Jani Taskinen <jani.taskinen@sci.fi> wrote:Pierre Joye [pierre.php@gmail.com] kirjoitti:It was correct as it was.Can you count to 2 ?? It's easy: 1, 2. Now, count how many levels it's to where the config.h would be if you do a phpize build:On Fri, Aug 15, 2008 at 6:00 PM, Jani Taskinen <jani.taskinen@sci.fi> wrote:Sorry, I can't count to 2 :) Should it not be in path anyway?ext/bcmath/libbcmath/src/bcmath.h Revert or I will and fix the correct bug.WHAT was fixed? It worked fine before you started messing around, what EXACTLY did you "fix" with this change?It is fixed with this commit, my comment may be wrong about ext/.config.h not found, what else can be fixed? :) -- Pierre http://blog.thepimp.net | http://www.libgd.org