Re: cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h

Hello Jani, hu? First there was the clean and the fix would have been to clean the correct file. Though the fix you did was fine as well. All I did was reminding about the clean section. Second, and that was the only other thing I commented on, was this one. And, well, ignore my ignorance, but because we have a bunch of bundled libs and because we have a ton of wrong include statements, including config.h is not alwas the correct one. I hate to say it but we either need to drop them and only include php.n or the php_config.h or fix the build system to generate correct includes and prevent from it from pulling in the wrong config.h or we could not do anything.... and ignore that there is a problem. Anyway, in case you feel personally aussaulted, sorry. marcus Friday, August 15, 2008, 6:49:08 PM, you wrote: > You don't really need to comment about everything, do you? > Please get your facts correct first. > --Jani > Marcus Boerger [helly@php.net] kirjoitti: >> Hello Jani, >> >> the real fix actually is to drop all #include config.h, because php needs >> to have php_config.h and not config.h as first file. >> >> marcus >> >> Friday, August 15, 2008, 6:37:24 PM, you wrote: >> >> > Not enough info -> bogus. >> >> > FYI: Just tested to be sure. Doing phpize build now fails. Works when reverted. >> > (reverted btw..) >> >> > I say again: Fix the REAL bugs, not symptoms of the real bugs.. >> >> > --Jani >> >> >> >> > Pierre Joye [pierre.php@gmail.com] kirjoitti: >> >> On Fri, Aug 15, 2008 at 6:30 PM, Jani Taskinen <jani.taskinen@sci.fi> wrote: >> >> > Pierre Joye [pierre.php@gmail.com] kirjoitti: >> >> >> >> >> >> On Fri, Aug 15, 2008 at 6:00 PM, Jani Taskinen >> >> >> <jani.taskinen@sci.fi> >> >> >> wrote: >> >> >> > Can you count to 2 ?? It's easy: 1, 2. >> >> >> > Now, count how many levels it's to where the config.h would be >> >> >> > if you do >> >> >> > a >> >> >> > phpize build: >> >> >> >> >> >> Sorry, I can't count to 2 :) >> >> >> >> >> >> Should it not be in path anyway? >> >> > >> >> > It was correct as it was. >> >> > >> >> >> > ext/bcmath/libbcmath/src/bcmath.h >> >> >> > >> >> >> > Revert or I will and fix the correct bug. >> >> >> >> >> >> It is fixed with this commit, my comment may be wrong about ext/. >> >> > >> >> > WHAT was fixed? It worked fine before you started messing around, what >> >> > EXACTLY did you "fix" with this change? >> >> >> >> config.h not found, what else can be fixed? :) >> >> >> >> >> >> -- >> >> Pierre >> >> http://blog.thepimp.net | >> >> http://www.libgd.org >> >> >> >> >> >> >> >> Best regards, >> Marcus >> >> >> -- >> PHP CVS Mailing List (http://www.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> Best regards, Marcus