Re: cvs: php-src /ext/hash CREDITS config.m4 hash.c /ext/hash/tests mhash_001.phpt mhash_002.phpt mhash_003.phpt skip_mhash.inc /ext/mhash config.m4
mhash.c mhash.dsp php_mhash.h /ext/mhash/tests 001.phpt 002.phpt 003.phpt skip.inc
| From: | Pierre Joye | Date: | Sat, 16 Aug 2008 22:19:22 +0000 |
| Subject: | Re: cvs: php-src /ext/hash CREDITS config.m4 hash.c /ext/hash/tests mhash_001.phpt mhash_002.phpt mhash_003.phpt skip_mhash.inc /ext/mhash config.m4 mhash.c mhash.dsp php_mhash.h /ext/mhash/tests 001.phpt 002.phpt 003.phpt skip.inc |
||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-52428@lists.php.net to get a copy of this message | ||
Hi,
On Sat, Aug 16, 2008 at 11:56 PM, Jani Taskinen <jani.taskinen@sci.fi> wrote:
>> Will $PHP_MHASH ever be anything here?
>> afaict ext/hash cannot be disabled after this change
>>
>> -Hannes
>>
>
> I wasn't paying attention to this..what was done for ext/mhash/config.m4? :)
> And == is not correct. It's just one = in m4.
>
> Anyway, IMO, you could simply move ext/mhash/*mhash.* (.c and .h files :) to
> ext/hash and simply include them with the hash sources. There's really no
> need anymore for the extra directory.
The idea behind keeping mhash was to allow:
if (extension_loaded('mhash'))
I did not not test the current version but what Jani suggests should
work. You can have two extension(..) in config.* (we do it for OCI8
with oci8_11g and oci8).
Cheers,
--
Pierre
http://blog.thepimp.net | http://www.libgd.org