Re: cvs: php-src(PHP_5_3) /ext/soap soap.c /ext/soap/tests/bugs bug31755.phpt
| From: | Dmitry Stogov | Date: | Mon, 15 Sep 2008 14:55:57 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_3) /ext/soap soap.c /ext/soap/tests/bugs bug31755.phpt | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-53156@lists.php.net to get a copy of this message | ||
Hi Felipe,
After this patch ext/soap may crash, because constructors may stay
ext/soap objects in inconsistent state.
<?php
$x = new soapclient;
$x->__setsoapheaders(array(1));
?>
To solve crashes it is possible to convert __constructor errors into
exceptions or revert the patch. I don't see a lot of reason in warnings
and exceptions because of wrong code. E_ERRORs were good enough for me.
Thanks. Dmitry.
Felipe Pena wrote:
> felipe Mon Sep 8 19:41:42 2008 UTC
>
> Modified files: (Branch: PHP_5_3)
> /php-src/ext/soap soap.c
> /php-src/ext/soap/tests/bugs bug31755.phpt
> Log:
> - MFH: Changed error level E_ERROR into E_WARNING in parameter validation
>
>