Re: cvs: php-src(PHP_5_3) /ext/soap soap.c /ext/soap/tests/bugs bug31755.phpt
| From: | Felipe Pena | Date: | Mon, 15 Sep 2008 18:09:45 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_3) /ext/soap soap.c /ext/soap/tests/bugs bug31755.phpt | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-53163@lists.php.net to get a copy of this message | ||
Hi Dmitry,
Em Seg, 2008-09-15 às 18:55 +0400, Dmitry Stogov escreveu:
> Hi Felipe,
>
> After this patch ext/soap may crash, because constructors may stay
> ext/soap objects in inconsistent state.
>
> <?php
> $x = new soapclient;
> $x->__setsoapheaders(array(1));
> ?>
Houston, we have a problem. :(
>
> To solve crashes it is possible to convert __constructor errors into
> exceptions or revert the patch. I don't see a lot of reason in warnings
> and exceptions because of wrong code. E_ERRORs were good enough for me.
>
> Thanks. Dmitry.
>
Ok, done. I added E_ERROR to constructors again. :)
Thanks!
--
Regards,
Felipe Pena.