Re: cvs: php-src(PHP_5_3) /ext/phar config.m4 util.c
| From: | Steph Fox | Date: | Tue, 04 Nov 2008 13:52:48 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_3) /ext/phar config.m4 util.c | ||
| References: | 1 2 3 4 5 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-53903@lists.php.net to get a copy of this message | ||
Args, sorry. I misread the commit and thought you'd removed the first line in that block, so yes the check is now correct in config.m4. But - since when is hash not optional? - StephNope. The *original* logic said 'is it there?' Greg changed that to 'is it !shared?' You changed it back to 'is it there?' It needs to be 'is it there && !shared?'read again. It says if it is shared then issue an error. If it is present then use it.