Re: cvs: php-src(PHP_5_3) /ext/phar config.m4 util.c
| From: | Marcus Boerger | Date: | Tue, 04 Nov 2008 13:54:59 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_3) /ext/phar config.m4 util.c | ||
| References: | 1 2 3 4 5 6 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-53904@lists.php.net to get a copy of this message | ||
Hello Steph,
Tuesday, November 4, 2008, 2:52:48 PM, you wrote:
>>> Nope. The *original* logic said 'is it there?' Greg changed that to 'is
>>> it
>>> !shared?' You changed it back to 'is it there?' It needs to be 'is
>>> it
>>> there
>>> && !shared?'
>>
>> read again. It says if it is shared then issue an error. If it is present
>> then use it.
> Args, sorry. I misread the commit and thought you'd removed the first line
> in that block, so yes the check is now correct in config.m4.
> But - since when is hash not optional?
It still is optional :-)
Only if it is shared we cannot rely on it for higher SHA.
Best regards,
Marcus