Re: cvs: php-src(PHP_5_2) / NEWS /ext/pcntl pcntl.c /ext/pcntl/tests 001.phpt bug47566.phpt
| From: | Antony Dovgal | Date: | Tue, 26 May 2009 15:09:03 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_2) / NEWS /ext/pcntl pcntl.c /ext/pcntl/tests 001.phpt bug47566.phpt | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-58251@lists.php.net to get a copy of this message | ||
On 26.05.2009 18:02, Arnaud Le Blanc wrote:
> - /* WEXITSTATUS only returns 8 bits so we *MUST* cast this to signed char
> - if you want to have valid negative exit codes */
> - RETURN_LONG((signed char) WEXITSTATUS(status_word));
> + RETURN_LONG(WEXITSTATUS(status_word));
Okay, now you CAN return 254, but you CAN'T return -2 anymore.
I'd say this needs to be reverted just to be consistent with previous versions.
--
Wbr,
Antony Dovgal
---
http://pinba.org - realtime statistics for PHP