Re: cvs: php-src(PHP_5_2) / NEWS /ext/pcntl pcntl.c /ext/pcntl/tests 001.phpt bug47566.phpt

Hi, On Tue, 2009-05-26 at 19:09 +0400, Antony Dovgal wrote: > On 26.05.2009 18:02, Arnaud Le Blanc wrote: > > - /* WEXITSTATUS only returns 8 bits so we *MUST* cast this to signed char > > - if you want to have valid negative exit codes */ > > - RETURN_LONG((signed char) WEXITSTATUS(status_word)); > > + RETURN_LONG(WEXITSTATUS(status_word)); > > Okay, now you CAN return 254, but you CAN'T return -2 anymore. > I'd say this needs to be reverted just to be consistent with previous versions. > proc_get_status() would return 254. A shell would say the script returned 254 too. C functions which return a process status would say 254 too. This was a bug and this should be fixed. I can revert this in 5.2, but IMO this should be left in other branches. Regards, Arnaud