Re: cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c
| From: | Pierre Joye | Date: | Thu, 11 Jun 2009 17:35:00 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c | ||
| References: | 1 2 3 4 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-58648@lists.php.net to get a copy of this message | ||
hi Andrey,
On Thu, Jun 11, 2009 at 7:25 PM, Andrey Hristov<Andrey.Hristov@sun.com> wrote:
> Hi Pierre,
> Pierre Joye wrote:
>>
>> hi,
>>
>> This change sounds wrong. The obj pointer is being used without being
>> initialized:
>>
>> ext\mysqlnd\mysqlnd_wireprotocol.c(1632) : warning C4700:
>> uninitialized local variable 'obj' used
>>
>> Cheers,
>
> Check with your eyes, the compiler is wrong.
> obj is touched only if allocated is FALSE but it is never FALSE if the zval
> cache has been switched off.
Please read http://www.thefreedictionary.com/seems
Now that the meaning of this word has been cleared :), can you add a
ifdef around that code then?
thanks for the quick reply,
Cheers,
--
Pierre
http://blog.thepimp.net | http://www.libgd.org