Re: cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

Hi Pierre, Pierre Joye wrote:

hi Andrey, On Thu, Jun 11, 2009 at 7:25 PM, Andrey Hristov<Andrey.Hristov@sun.com> wrote:

Hi Pierre, Pierre Joye wrote:

hi, This change sounds wrong. The obj pointer is being used without being initialized: ext\mysqlnd\mysqlnd_wireprotocol.c(1632) : warning C4700: uninitialized local variable 'obj' used Cheers,

Check with your eyes, the compiler is wrong. obj is touched only if allocated is FALSE but it is never FALSE if the zval cache has been switched off.

Please read http://www.thefreedictionary.com/seems Now that the meaning of this word has been cleared :), can you add a ifdef around that code then? thanks for the quick reply,

no :) But you can send the case to your colleagues at the compiler team so they can analyze why the compiler failed to recognize it :) I like the MS compiler, it gives more warnings than gcc, but in this case was wrong :( I am curious why it does complain about one line although there are few places where obj is used and guarded by that allocated variable. Best, Andrey