cvs: php4 /ext/mysql php_mysql.c
| From: | Zeev Suraski | Date: | Wed, 05 Jul 2000 20:41:08 +0000 |
| Subject: | cvs: php4 /ext/mysql php_mysql.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-636@lists.php.net to get a copy of this message | ||
zeev Wed Jul 5 13:41:08 2000 EDT
Modified files:
/php4/ext/mysql php_mysql.c
Log:
That's no bug, it's quite fine the way it is (if id is
set to -1, it's ignored, and the passed_id argument is used).
If you're experiencing trouble with mysql_close(), please give me a
reproducing script. If there's a bug, it's not as simple as that.
Index: php4/ext/mysql/php_mysql.c
diff -u php4/ext/mysql/php_mysql.c:1.50 php4/ext/mysql/php_mysql.c:1.51
--- php4/ext/mysql/php_mysql.c:1.50 Wed Jul 5 12:48:24 2000
+++ php4/ext/mysql/php_mysql.c Wed Jul 5 13:41:06 2000
@@ -16,7 +16,7 @@
+----------------------------------------------------------------------+
*/
-/* $Id: php_mysql.c,v 1.50 2000/07/05 19:48:24 steinm Exp $ */
+/* $Id: php_mysql.c,v 1.51 2000/07/05 20:41:06 zeev Exp $ */
/* TODO:
@@ -598,9 +598,6 @@
}
ZEND_FETCH_RESOURCE2(mysql, MYSQL *, mysql_link, id, "MySQL-Link", le_link, le_plink);
-
- /* XXX shouldn't this be zend_list_delete((*mysql_link)->value.lval)
- * if the optional parameter is present? (steinm@php.net) */
zend_list_delete(id);
RETURN_TRUE;
}