Re: cvs: php4 /ext/mysql php_mysql.c
| From: | Jouni Ahto | Date: | Thu, 06 Jul 2000 19:47:14 +0000 |
| Subject: | Re: cvs: php4 /ext/mysql php_mysql.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-654@lists.php.net to get a copy of this message | ||
On Wed, 5 Jul 2000, Zeev Suraski wrote:
> zeev Wed Jul 5 13:41:08 2000 EDT
>
> Modified files:
> /php4/ext/mysql php_mysql.c
> Log:
> That's no bug, it's quite fine the way it is (if id is
> set to -1, it's ignored, and the passed_id argument is used).
That doesn't seem to be Uwes point... after ZEND_FETCH_RESOURCE(...), id
is still -1. How could zend_list_delete(-1) have any hope of doing
something?
-- Jouni
> -/* $Id: php_mysql.c,v 1.50 2000/07/05 19:48:24 steinm Exp $ */
> +/* $Id: php_mysql.c,v 1.51 2000/07/05 20:41:06 zeev Exp $ */
>
>
> /* TODO:
> @@ -598,9 +598,6 @@
> }
>
> ZEND_FETCH_RESOURCE2(mysql, MYSQL *, mysql_link, id, "MySQL-Link", le_link,
> le_plink);
> -
> - /* XXX shouldn't this be zend_list_delete((*mysql_link)->value.lval)
> - * if the optional parameter is present? (steinm@php.net) */
> zend_list_delete(id);
> RETURN_TRUE;
> }