Re: svn: /php/php-src/ branches/PHP_5_3/ext/exif/exif.c branches/PHP_5_3/ext/exif/tests/bug54002.phpt branches/PHP_5_3/ext/exif/tests/bug54002_1.jpeg
branches/PHP_5_3/ext/exif/tests/bug54002_2.jpeg trunk/ext/exif/exif.c trunk/ext/exif/tests/bug54002.phpt trunk/ext/exif/tests/bug54002_1.jpeg
trunk/ext/exif/tests/bug54002_2.jpeg
| From: | Dmitry Stogov | Date: | Tue, 15 Feb 2011 09:17:20 +0000 |
| Subject: | Re: svn: /php/php-src/ branches/PHP_5_3/ext/exif/exif.c branches/PHP_5_3/ext/exif/tests/bug54002.phpt branches/PHP_5_3/ext/exif/tests/bug54002_1.jpeg branches/PHP_5_3/ext/exif/tests/bug54002_2.jpeg trunk/ext/exif/exif.c trunk/ext/exif/tests/bug54002.phpt trunk/ext/exif/tests/bug54002_1.jpeg trunk/ext/exif/tests/bug54002_2.jpeg |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-64550@lists.php.net to get a copy of this message | ||
Hi Pierre,
The check for (byte_count_signed > 2147483648) looks ugly and it's even wrong.
It should be changed to something like (byte_count_signed > INT32_MAX) where INT32_MAX = 0x7fffffff (or 2147483647).
Thanks. Dmitry.
On 02/14/2011 12:08 PM, Pierre Joye wrote:
(byte_count_signed> 2147483648)