Re: svn: /php/php-src/ branches/PHP_5_3/ext/exif/exif.c branches/PHP_5_3/ext/exif/tests/bug54002.phpt branches/PHP_5_3/ext/exif/tests/bug54002_1.jpeg
branches/PHP_5_3/ext/exif/tests/bug54002_2.jpeg trunk/ext/exif/exif.c trunk/ext/exif/tests

On Tue, Feb 15, 2011 at 10:17 AM, Dmitry Stogov <dmitry@zend.com> wrote: > Hi Pierre, > > The check for (byte_count_signed > 2147483648) looks ugly and it's even > wrong. It is not ugly nor wrong. See my post in when I proposed the patch. It should actually be something much lower but I did not find a reliable reference for this value (max length of a tag value). > It should be changed to something like (byte_count_signed > INT32_MAX) where > INT32_MAX = 0x7fffffff (or 2147483647). Yes, using a constant could be nice, I will check if that one is actually always available. Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org