Re: svn: /php/php-src/ branches/PHP_5_3/ext/exif/exif.c branches/PHP_5_3/ext/exif/tests/bug54002.phpt branches/PHP_5_3/ext/exif/tests/bug54002_1.jpeg
branches/PHP_5_3/ext/exif/tests/bug54002_2.jpeg trunk/ext/exif/exif.c trunk/ext/exif/tests
| From: | Dmitry Stogov | Date: | Tue, 15 Feb 2011 11:54:06 +0000 |
| Subject: | Re: svn: /php/php-src/ branches/PHP_5_3/ext/exif/exif.c branches/PHP_5_3/ext/exif/tests/bug54002.phpt branches/PHP_5_3/ext/exif/tests/bug54002_1.jpeg branches/PHP_5_3/ext/exif/tests/bug54002_2.jpeg trunk/ext/exif/exif.c trunk/ext/exif/tests |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-64552@lists.php.net to get a copy of this message | ||
On 02/15/2011 12:31 PM, Pierre Joye wrote:
On Tue, Feb 15, 2011 at 10:17 AM, Dmitry Stogov<dmitry@zend.com> wrote:I don't know all the logic but it looks very strange 2147483648 == 0x80000000 != 0x7fffffff == 2147483647 so byte_count_signed may be 0x80000000 == -1 Thanks. Dmitry.Hi Pierre, The check for (byte_count_signed> 2147483648) looks ugly and it's even wrong.It is not ugly nor wrong. See my post in when I proposed the patch. It should actually be something much lower but I did not find a reliable reference for this value (max length of a tag value).
It should be changed to something like (byte_count_signed> INT32_MAX) where INT32_MAX = 0x7fffffff (or 2147483647).Yes, using a constant could be nice, I will check if that one is actually always available. Cheers,