Re: svn: /php/php-src/ branches/PHP_5_3/ext/exif/exif.c branches/PHP_5_3/ext/exif/tests/bug54002.phpt branches/PHP_5_3/ext/exif/tests/bug54002_1.jpeg
branches/PHP_5_3/ext/exif/tests/bug54002_2.jpeg trunk/ext/exif/exif.c trunk/ext/exif/tests
| From: | Pierre Joye | Date: | Tue, 15 Feb 2011 12:31:39 +0000 |
| Subject: | Re: svn: /php/php-src/ branches/PHP_5_3/ext/exif/exif.c branches/PHP_5_3/ext/exif/tests/bug54002.phpt branches/PHP_5_3/ext/exif/tests/bug54002_1.jpeg branches/PHP_5_3/ext/exif/tests/bug54002_2.jpeg trunk/ext/exif/exif.c trunk/ext/exif/tests |
||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-64553@lists.php.net to get a copy of this message | ||
On Tue, Feb 15, 2011 at 12:54 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> I don't know all the logic but it looks very strange
>
> 2147483648 == 0x80000000 != 0x7fffffff == 2147483647
>
> so byte_count_signed may be 0x80000000 == -1
negative value are checked before. Btw, byte_count_signed is a 64bit
signed integer, for this reason :)
Cheers,
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org