Re: cvs: php4 /ext/curl curl.c /ext/db db.c /ext/domxml php_domxml.c /ext/fdf fdf.c /ext/gd gd.c /ext/hyperwave hw.c /ext/interbase
interbase.c /ext/mhash mhash.c /ext/odbc php_odbc.c /ext/sablot sablot.c /ext/session session.c /ext/snmp snmp.c /ext/sockets sockets.c
/ext/standard basic_functions.c info.c

That's a *very* inefficient way of doing this. Why not just if (ZEND_NUM_ARGS()==0) {

        ZEND_WRONG_PARAM_COUNT();

} ? At 09:43 13-08-01, Rasmus Lerdorf wrote:

rasmus          Mon Aug 13 02:43:48 2001 EDT

Modified files:

    /php4/ext/curl      curl.c
    /php4/ext/db        db.c
    /php4/ext/domxml    php_domxml.c
    /php4/ext/fdf       fdf.c
    /php4/ext/gd        gd.c
    /php4/ext/hyperwave hw.c
    /php4/ext/interbase interbase.c
    /php4/ext/mhash     mhash.c
    /php4/ext/odbc      php_odbc.c
    /php4/ext/sablot    sablot.c
    /php4/ext/session   session.c
    /php4/ext/snmp      snmp.c
    /php4/ext/sockets   sockets.c
    /php4/ext/standard  basic_functions.c info.c

Log: We don't consistently check for args passed to functions that don't take any args. In some cases we probably want to skip the check for performance reasons, but in other cases where performance is unlikely to be a factor, not throwing a warning on the wrong number of args passed to a function is at best inconsistent, and at worst it could hide a bug. So, add a few such checks. There are still lots of cases out there. -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, e-mail: php-cvs-unsubscribe@lists.php.net For additional commands, e-mail: php-cvs-help@lists.php.net To contact the list administrators, e-mail: php-list-admin@lists.php.net

-- Zeev Suraski <zeev@zend.com> CTO & co-founder, Zend Technologies Ltd. http://www.zend.com/