Re: cvs: php4 /ext/curl curl.c /ext/db db.c /ext/domxml php_domxml.c /ext/fdf fdf.c /ext/gd gd.c /ext/hyperwave hw.c /ext/interbase
interbase.c /ext/mhash mhash.c /ext/odbc php_od

At 10:35 13-08-01, Rasmus Lerdorf wrote:

That's a *very* inefficient way of doing this. Why not just if (ZEND_NUM_ARGS()==0) {

         ZEND_WRONG_PARAM_COUNT();

} You mean != 0 there

Yeah.

The warning message is clearer. But yes, I realize it isn't super efficient and thus didn't touch stuff that might be speed sensitive.

So we can add a new macro... Calling a super complex function when all you want is a comparison with zero is bloat, even if we're dealing with a non performance sensitive function... Zeev