Re: com php-src: Fixed bug #61728 (php-fpm SIGSEGV running friendica on nginx): NEWS ext/session/tests/bug61728.phpt main/main.c
| From: | Laruence | Date: | Sun, 15 Apr 2012 05:00:38 +0000 |
| Subject: | Re: com php-src: Fixed bug #61728 (php-fpm SIGSEGV running friendica on nginx): NEWS ext/session/tests/bug61728.phpt main/main.c | ||
| References: | 1 2 3 4 5 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-68781@lists.php.net to get a copy of this message | ||
On Sun, Apr 15, 2012 at 12:36 PM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> Hi!
>
>>> I'm not sure this is a good idea - output buffers can include output
>>> functions IIRC, but you have already shut down modules. I would be very,
>> Stas, they are request shutdown, not module shutdown :)
>
> Request shutdown IIRC destroys functions and module's per-request data
> structures, which user-supplied output handlers may need. Did you check
> that user-supplied output handlers - especially those that use
> extensions and per-request data structures - actually work after this
> change?
Ah, thanks, I got your point. but output handler is called in step 3:
/* 3. Flush all output buffers */
and as I said, all tests passed.
anyway, you are right, we should be careful, I will double check it. :)
thanks
>
> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227
--
Laruence Xinchen Hui
http://www.laruence.com/