Re: com php-src: Bug 61504 updated libmagic.patch: ext/fileinfo/libmagic.patch

Hi Chris, that's not documented on the php.net yet. I think shortening that notice is a good idea. Probably it should just stop on the first fail and warn about the incompatibility. Cheers Anatoliy Am Fr, 4.05.2012, 21:38 schrieb Christopher Jones: > > > > On 05/04/2012 11:16 AM, Anatoliy Belsky wrote: >> Hi Chris, >> >> please see my comment in the #61940. >> >> Regards >> >> Anatoliy > > Hi Anatoliy, > > Is this documented on php.net? > > I agree with Sean that the error messages are useless. Is there anyway PHP > can > improve on them? > > Thanks for looking at it, > > Chris > >> >> Am Fr, 4.05.2012, 19:16 schrieb Christopher Jones: >>> >>> >>> On 03/28/2012 03:06 AM, Anatoliy Belsky wrote: >>>> Commit: 11f04c3524cc86a5c4cdf748a107801116604184 >>>> Author: Anatoliy Belsky<ab@php.net> Wed, 28 Mar 2012 >>>> 12:06:09 +0200 >>>> Parents: e7fa402c7ccbff8a6ff8af776192416747db0d77 >>>> Branches: PHP-5.3 PHP-5.4 master >>>> >>>> Link: >>>> >>>> http://git.php.net/?p=php-src.git;a=commitdiff;h=11f04c3524cc86a5c4cdf748a107801116604184 >>>> >>>> Log: >>>> Bug 61504 updated libmagic.patch >>>> >>>> Bugs: >>>> https://bugs.php.net/61504 >>>> >>>> Changed paths: >>>> M ext/fileinfo/libmagic.patch >>>> >>>> >>>> >>>> >>> >>> Anatoliy, Pierre, >>> >>> Can you review https://bugs.php.net/bug.php?id=61940 >>> which claims the >>> fix >>> for 61504 broke it. >>> >>> Thanks, >>> >>> Chris >>> >>> -- >>> christopher.jones@oracle.com >>> http://twitter.com/#!/ghrd >>> >> >> > > -- > christopher.jones@oracle.com > http://twitter.com/#!/ghrd >