Re: com php-src: Bug 61504 updated libmagic.patch: ext/fileinfo/libmagic.patch

Sean, thanks for reporting that :) Chris, theoretically there were a possibility to apply the patch for 5.04 which was made first (it's attached in #61504) ... but I wouldn't call that quite rational. As Sean mentioned, it's already done. For the current patch 5.11 tests was fixed, some fixes was done over it, and it's released. Besides this, patching for 7 versions forwards wasn't that easy, so the longer it's waiting, the worst it gets. Therefore I'd really suggest here to document this and to make the warnings more meaningful. Hannes, I agree here even more than you :) . But, that was a security conditioned upgrade. The patch for 5.04 has existed shortly before the patch 5.11, but finally the 5.11 one was considered as better. The notices come directly from libmagic, so no wonder some of them are not handled properly (and they were not before). The development was concentrated more on the usage with the compiled in data (as use of the externals is rare), so I think at the end of he day a security fix is worth it. Thanks for the help guys and regards Anatoliy On Fri, 04 May 2012 15:02:21 -0700 Christopher Jones <christopher.jones@oracle.com> wrote: > > > On 05/04/2012 02:22 PM, Anatoliy Belsky wrote: > > Hi Chris, > > > > that's not documented on the php.net yet. > > > > I think shortening that notice is a good idea. Probably it should just > > stop on the first fail and warn about the incompatibility. > > > > Cheers > > > > Anatoliy > > > > Hi Anatoliy, > > What are the options for reverting this fix (while keeping security)? > > Do you have an action item to document it the change? > (https://edit.php.net/ is a convenient way to update doc) > > Chris > > -- > christopher.jones@oracle.com > http://twitter.com/#!/ghrd -- Anatoliy Belsky <ab@php.net>