Re: com php-src: Add missing E_DEPRECATED error for https://wiki.php.net/rfc/default_encoding: UPGRADING ext/iconv/iconv.c
ext/iconv/tests/iconv_encoding_basic.phpt ext/iconv/tests/iconv_get_encoding_basic.phpt ext/iconv/tests/iconv_ini_encoding.phpt
ext/iconv/tests/iconv_set_encoding_variation.phpt ext/iconv/tests/iconv_strpos_basic.phpt ext/iconv/tests/iconv_strpos_variation5.phpt
ext/iconv/tests/iconv_strrpos_basic.phpt ext/mbstring/mbstring.c ext

On Thu, Mar 20, 2014 at 9:39 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote: > Hi Ferenc, > > On Thu, Mar 20, 2014 at 5:13 PM, Ferenc Kovacs <tyra3l@gmail.com> wrote: > >> you removed the XFAIL from two multibyte tests which are still >> failing(ext/mbstring/tests/zend_multibyte-02.phpt and >> ext/mbstring/tests/zend_multibyte-06.phpt), I'm putting those back until >> these tests actually pass. >> https://travis-ci.org/php/php-src/builds/21081867 >> next time you can check the travis build result yourself before merging >> the PR to catch errors like this (or just run the tests locally). >> > > OK. Thanks. > It doesn't fail on my environment. > I'll take care of the issue, but it would be in the future. > These tests should be taken care of when zend.multibyte became INI > option. If anyone could fix this, please do so. > > Regards, > > -- > Yasuo Ohgaki > yohgaki@ohgaki.net > Hi, from quick look, it seems that the only thing preventing -02 and -06 from passing is the missing 'Aborted' from the expected test output: https://travis-ci.org/php/php-src/builds/21145878 Ofc course it is still horrible, that we have an assert in the code, which can be triggered from the userland with simple ini values, and that these tests are currently expecting the code to bail out from the execution there.. -- Ferenc Kovács @Tyr43l - http://tyrael.hu