Re: com php-src: Add missing E_DEPRECATED error for https://wiki.php.net/rfc/default_encoding: UPGRADING ext/iconv/iconv.c
ext/iconv/tests/iconv_encoding_basic.phpt ext/iconv/tests/iconv_get_encoding_basic.phpt ext/iconv/tests/iconv_ini_encoding.phpt
ext/iconv/tests/iconv_set_encoding_variation.phpt ext/iconv/tests/iconv_strpos_basic.phpt ext/iconv/tests/iconv_strpos_variation5.phpt
ext/iconv/tests/iconv_strrpos_basic.phpt ext/mbstring/mbstring.c ext

From: Date: Thu, 20 Mar 2014 08:59:53 +0000
Subject: Re: com php-src: Add missing E_DEPRECATED error for https://wiki.php.net/rfc/default_encoding: UPGRADING ext/iconv/iconv.c
ext/iconv/tests/iconv_encoding_basic.phpt ext/iconv/tests/iconv_get_encoding_basic.phpt ext/iconv/tests/iconv_ini_encoding.phpt
ext/iconv/tests/iconv_set_encoding_variation.phpt ext/iconv/tests/iconv_strpos_basic.phpt ext/iconv/tests/iconv_strpos_variation5.phpt
ext/iconv/tests/iconv_strrpos_basic.phpt ext/mbstring/mbstring.c ext
References: 1 2 3 4  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-76553@lists.php.net to get a copy of this message
Hi Ferenc, On Thu, Mar 20, 2014 at 5:51 PM, Ferenc Kovacs <tyra3l@gmail.com> wrote: > from quick look, it seems that the only thing preventing -02 and -06 from > passing is the missing 'Aborted' from the expected test output: > https://travis-ci.org/php/php-src/builds/21145878 > > Ofc course it is still horrible, that we have an assert in the code, which > can be triggered from the userland with simple ini values, and that these > tests are currently expecting the code to bail out from the execution there. > Yes. It is horrible... I think simple validation is missing in mbstring or Zend Engine. It would be in Zend Engine most likely, I guess. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net

« previous php.cvs (#76553) next »