Re: com php-src: add missing skip to the output, so we actually skip this test: sapi/cli/tests/upload_2G.phpt

hi, I've only fixed the skipif part (the output of the skipif has to begin with skip for us to actually skip the test). we could check SKIP_SLOW_TESTS for this test, and maybe it would be also nice if we could create some basic functionality for getting the amount of free memory, as this isn't the first time where we allocating large amounts of memory for a test and have to check beforehand (see also Zend/tests/bug55509.phpt) if you think that you can remove/decrease the memory requirements for this test via explicitly setting the upload_dir or similar, then please go ahead! On Tue, Apr 8, 2014 at 9:50 AM, Michael Wallner <mike@php.net> wrote: > Just because you reminded me: This is actually only true if upload_dir > points to a tmpfs, which was the case with my /tmp. We might stay on > the safe side leaving this in, though :) > > On 7 April 2014 16:57, Ferenc Kovacs <tyrael@php.net> wrote: > > Commit: 7446766dabf6995ec7136e6da8fa5c1573696785 > > Author: Ferenc Kovacs <tyrael@php.net> Mon, 7 Apr 2014 > 16:57:52 +0200 > > Parents: 63e7b845933424cbc97daa6b8e727c07a1a7ea73 > > Branches: PHP-5.6 > > > > Link: > > http://git.php.net/?p=php-src.git;a=commitdiff;h=7446766dabf6995ec7136e6da8fa5c1573696785 > > > > Log: > > add missing skip to the output, so we actually skip this test > > > > Changed paths: > > M sapi/cli/tests/upload_2G.phpt > > > > > > Diff: > > diff --git a/sapi/cli/tests/upload_2G.phpt > b/sapi/cli/tests/upload_2G.phpt > > index 707eddb..313dcd5 100644 > > --- a/sapi/cli/tests/upload_2G.phpt > > +++ b/sapi/cli/tests/upload_2G.phpt > > @@ -19,7 +19,7 @@ if ($f = fopen("/proc/meminfo","r")) { > > } > > > > if (empty($enough_free_ram)) { > > - die("need +3G free RAM"); > > + die("skip need +3G free RAM"); > > } > > ?> > > --FILE-- > > > > > > -- > > PHP CVS Mailing List (http://www.php.net/) > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > > > -- > Regards, > Mike >