Re: com php-src: add missing skip to the output, so we actually skip this test: sapi/cli/tests/upload_2G.phpt

On 08 04 2014, at 10:20, Ferenc Kovacs <tyrael@php.net> wrote: > hi, > > I've only fixed the skipif part (the output of the skipif has to begin with skip for us to > actually skip the test). Yup. > we could check SKIP_SLOW_TESTS Ah, yes, definitely. Chris wanted that already. > for this test, and maybe it would be also nice if we could create some basic functionality for > getting the amount of free memory, as this isn't the first time where we allocating large > amounts of memory for a test and have to check beforehand (see also Zend/tests/bug55509.phpt) > > if you think that you can remove/decrease the memory requirements for this test via explicitly > setting the upload_dir or similar, then please go ahead! Ha, why didn’t I think of that, of course! :) Cheers, Mike