Re: com php-src: Fix bug #64330: NEWS ext/standard/tests/network/bug64330.phpt main/streams/xp_socket.c

On 08 04 2014, at 13:14, Ferenc Kovacs <tyra3l@gmail.com> wrote: > > > > On Wed, Apr 2, 2014 at 11:09 AM, Michael Wallner <mike@php.net> wrote: > Commit: 91a9d24aa30507e6c7d8937db2de24394f0ce121 > Author: Michael Wallner <mike@php.net> Wed, 2 Apr 2014 11:09:26 +0200 > Parents: f244513fc059a9b7ee2b91ad65f1a2f013b5d588 > Branches: PHP-5.4 PHP-5.5 PHP-5.6 master > > Link: > http://git.php.net/?p=php-src.git;a=commitdiff;h=91a9d24aa30507e6c7d8937db2de24394f0ce121 > > Log: > Fix bug #64330 > > stream_socket_server() creates wrong Abstract Namespace UNIX sockets > > Bugs: > https://bugs.php.net/64330 > > Hi Mike, > > this test fails for me on Mac OS X, based on a prompt search I think the abstract unix socket > is a linux-only feature: Oh silly me, of course! > > http://man7.org/linux/man-pages/man7/unix.7.html > "Linux also supports an abstract namespace which is independent of the filesystem." > > https://bugs.php.net/bug.php?id=16121 > > http://www.freebsd.org/cgi/man.cgi?query=unix&apropos=0&sektion=0&manpath=FreeBSD+10.0-RELEASE&arch=default&format=html > > As far as I can tell the patch itself doesn't require any modification as it fails as I > would try to open a non existent path: > 002+ > 003+ Warning: stream_socket_server(): unable to connect to unix:// (Unknown error) in > /Users/tyrael/checkouts/php-src.git/ext/standard/tests/network/bug64330.php on line 3 > 004+ > 005+ Warning: stream_socket_client(): unable to connect to unix://\0/MyBindName (No such file > or directory) in /Users/tyrael/checkouts/php-src.git/ext/standard/tests/network/bug64330.php on line > 4 > 002- ok > > > so I think the only thing needs fixing is adding a skipif for non everything but linux. > > -- > Ferenc Kovács > @Tyr43l - http://tyrael.hu