Re: cvs: php4 /ext/standard basic_functions.c

On Wed, Oct 10, 2001 at 07:13:22PM +0200, Andi Gutmans wrote: > At 11:43 AM 10/10/2001 -0500, Andrei Zmievski wrote: > >On Wed, 10 Oct 2001, Andi Gutmans wrote: > > > Stig, > > > > > > Can we please keep these function names consistent with the PHP way and > > not > > > with Perl? We decided a long time ago to use significant function names, > > > i.e., version_equals(). Also, do we really need all of those? > > > >Yes, why not version_check($version1, $version2, 'equal'), and so on. > > Yeah I also thought of something like that. We could have constants such as > VERSION_EQUAL. How about using '==', '<', '>' etc.? version_check($version1, $version2, '=') But perhaps version_compare() returning -1, 0, 1 is the best. I liked the idea of splitting it up in major, minor, etc. It should then should be possible to compare majors for instance. If we have a function returning just the major one could perhaps do version_check(version_major($version1), version_major($version2),... Stig