Re: cvs: php4 /ext/standard basic_functions.c
| From: | Stig S. Bakken | Date: | Thu, 11 Oct 2001 06:48:23 +0000 |
| Subject: | Re: cvs: php4 /ext/standard basic_functions.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-7758@lists.php.net to get a copy of this message | ||
Huh, Perl? I got this from /bin/sh ;-)
But I can add a third parameter to version_compare if people think
having 5 extra functions is overkill.
- Stig
Andi Gutmans wrote:
>
> Stig,
>
> Can we please keep these function names consistent with the PHP way and not
> with Perl? We decided a long time ago to use significant function names,
> i.e., version_equals(). Also, do we really need all of those?
>
> Andi
>
> At 10:32 AM 10/10/2001 +0000, Stig Bakken wrote:
> >ssb Wed Oct 10 06:32:17 2001 EDT
> >
> > Modified files:
> > /php4/ext/standard basic_functions.c
> > Log:
> > * added function entries for version_{lt,le,gt,ge,eq}
> >
> >
> >Index: php4/ext/standard/basic_functions.c
> >diff -u php4/ext/standard/basic_functions.c:1.405
> >php4/ext/standard/basic_functions.c:1.406
> >--- php4/ext/standard/basic_functions.c:1.405 Sun Oct 7 14:34:44 2001
> >+++ php4/ext/standard/basic_functions.c Wed Oct 10 06:32:16 2001
> >@@ -17,7 +17,7 @@
> > +----------------------------------------------------------------------+
> > */
> >
> >-/* $Id: basic_functions.c,v 1.405 2001/10/07 18:34:44 derick Exp $ */
> >+/* $Id: basic_functions.c,v 1.406 2001/10/10 10:32:16 ssb Exp $ */
> >
> > #include "php.h"
> > #include "php_main.h"
> >@@ -792,6 +792,11 @@
> >
> > /* functions from versioning.c */
> > PHP_FE(version_compare,
> > NULL)
> >+ PHP_FE(version_lt,
> > NULL)
> >+ PHP_FE(version_le,
> > NULL)
> >+ PHP_FE(version_gt,
> > NULL)
> >+ PHP_FE(version_ge,
> > NULL)
> >+ PHP_FE(version_eq,
> > NULL)
> >
> > {NULL, NULL, NULL}
> > };