Re: com php-src: Fix spl_directory cast_object, reenable error: Zend/zend_execute.h ext/spl/spl_directory.c
| From: | Nikita Popov | Date: | Tue, 13 May 2014 17:07:37 +0000 |
| Subject: | Re: com php-src: Fix spl_directory cast_object, reenable error: Zend/zend_execute.h ext/spl/spl_directory.c | ||
| References: | 1 2 3 4 5 6 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-78319@lists.php.net to get a copy of this message | ||
On Tue, May 13, 2014 at 6:55 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> I restored comments above this warning. you may add your explanation there
> to be not forgotten.
> We'll have to decide about it later.
>
> I see two disadvantages:
> 1) it changes behavior in som cases
> 2) it addes code in inline function that is going to be duplicated all
> around the code (later it;s going to be JIT-ed).
>
If that's an issue, then we shouldn't inline the IS_OBJECT case altogether.
Our other inlined conversion macros (zendi_convert_*) also do a separate
function call to convert_to_* to handle the object casts.
Nikita