Re: com php-src: Fix spl_directory cast_object, reenable error: Zend/zend_execute.h ext/spl/spl_directory.c

yes :) this is an option, I thought about. BTW: I didn't think about all conversion macros. Can you try separating "slow paths" into non-inlined functions and check the difference? don't commit yet, if it doesn't make gain. Thanks. Dmitry. On Tue, May 13, 2014 at 9:07 PM, Nikita Popov <nikita.ppv@gmail.com> wrote: > On Tue, May 13, 2014 at 6:55 PM, Dmitry Stogov <dmitry@zend.com> wrote: > >> I restored comments above this warning. you may add your explanation >> there to be not forgotten. >> We'll have to decide about it later. >> >> I see two disadvantages: >> 1) it changes behavior in som cases >> 2) it addes code in inline function that is going to be duplicated all >> around the code (later it;s going to be JIT-ed). >> > > If that's an issue, then we shouldn't inline the IS_OBJECT case > altogether. Our other inlined conversion macros (zendi_convert_*) also do a > separate function call to convert_to_* to handle the object casts. > > Nikita >