Re: com php-src: Fixed version checking: ext/mysqli/mysqli.c
| From: | Derick Rethans | Date: | Fri, 15 Aug 2014 11:18:22 +0000 |
| Subject: | Re: com php-src: Fixed version checking: ext/mysqli/mysqli.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-80544@lists.php.net to get a copy of this message | ||
On Fri, 15 Aug 2014, Xinchen Hui wrote:
> Commit: 0583b3bd6a52617b597ea5275aec2f8c545fcbf4
> Author: Xinchen Hui <laruence@php.net> Fri, 15 Aug 2014 18:28:41 +0800
> Parents: 7ace092abfec31749da230405a7298d9b5789f43
> Branches: master
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=0583b3bd6a52617b597ea5275aec2f8c545fcbf4
>
> Log:
> Fixed version checking
>
> Changed paths:
> M ext/mysqli/mysqli.c
>
>
> Diff:
> diff --git a/ext/mysqli/mysqli.c b/ext/mysqli/mysqli.c
> index 9374737..fb93095 100644
> --- a/ext/mysqli/mysqli.c
> +++ b/ext/mysqli/mysqli.c
> @@ -995,7 +995,7 @@ PHP_MINFO_FUNCTION(mysqli)
>
> /* Dependancies */
> static const zend_module_dep mysqli_deps[] = {
> -#if defined(HAVE_SPL) && ((PHP_MAJOR_VERSION > 5) || (PHP_MAJOR_VERSION == 5
> && PHP_MINOR_VERSION >= 1))
> +#if defined(HAVE_SPL) && (PHP_VERSION_ID >= 50100)
I don't think this is correct, as PHP_VERSION_ID only got introduced in
PHP 5.2.
cheers,
Derick