Re: com php-src: Fixed version check: ext/mysqli/mysqli.c
| From: | Pierre Joye | Date: | Fri, 15 Aug 2014 13:48:20 +0000 |
| Subject: | Re: com php-src: Fixed version check: ext/mysqli/mysqli.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-80545@lists.php.net to get a copy of this message | ||
On Fri, Aug 15, 2014 at 12:21 PM, Xinchen Hui <laruence@php.net> wrote:
> Commit: 7ace092abfec31749da230405a7298d9b5789f43
> Author: Xinchen Hui <laruence@php.net> Fri, 15 Aug 2014 18:21:23 +0800
> Parents: 29893a88e7cdf93f9ce80ce7eaecffb3ef5e30c9
> Branches: master
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=7ace092abfec31749da230405a7298d9b5789f43
>
> Log:
> Fixed version check
>
> Changed paths:
> M ext/mysqli/mysqli.c
>
>
> Diff:
> diff --git a/ext/mysqli/mysqli.c b/ext/mysqli/mysqli.c
> index 43d471d..9374737 100644
> --- a/ext/mysqli/mysqli.c
> +++ b/ext/mysqli/mysqli.c
> @@ -585,7 +585,7 @@ PHP_MINIT_FUNCTION(mysqli)
> mysqli_object_handlers.write_property = mysqli_write_property;
> mysqli_object_handlers.get_property_ptr_ptr = std_hnd->get_property_ptr_ptr;
> mysqli_object_handlers.has_property = mysqli_object_has_property;
> -#if PHP_MAJOR_VERSION == 5 && PHP_MINOR_VERSION >= 3
> +#if PHP_VERSION_ID >= 53000
> mysqli_object_handlers.get_debug_info = mysqli_object_get_debug_info;
> #endif
> memcpy(&mysqli_object_driver_handlers, &mysqli_object_handlers,
> sizeof(zend_object_handlers));
Given the amount of changes in the extensions I wonder why we even
keep this kind of things in master. Could we not simply clean that up?
Cheers,
--
Pierre
@pierrejoye | http://www.libgd.org