Re: Broken tests
| From: | Xinchen Hui | Date: | Fri, 26 Dec 2014 14:50:41 +0000 |
| Subject: | Re: Broken tests | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-83872@lists.php.net to get a copy of this message | ||
Hey:
On Fri, Dec 26, 2014 at 10:18 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> Hi Xinchen,
>
> The commit c2a047cf99f3d020bab12701e8dafed7424673bf made few tests to start
> fail on 32-bit DEBUG build. The same tests seems to work in RELEASE build.
>
> Are you sure these the are changed in a proper way?
> For me it looks like something was broken in code, and then tests were
> adjusted for wrong new behaviour.
>
> Please, find the source of the problem.
okey, it really looks like related to precision
I am going to revert it first, then refix it
thanks
>
> Thanks. Dmitry.
>
>> mysqli fetch float values [ext/mysqli/tests/010.phpt]
>> mysqli fetch mixed values [ext/mysqli/tests/011.phpt]
>> mysqli fetch mixed values 2 [ext/mysqli/tests/012.phpt]
>
> $ cat ../ext/mysqli/tests/010.diff
> 003+ float(3.141593)
> 003- float(3.14159274101)
> 005+ float(-1.0E-6)
> 005- float(-9.99999997475E-7)
> 009+ float(1.0E+12)
> 009- float(999999995904)
> 011+ float(0.5646425)
> 011- float(0.564642488956)
> 015+ float(8.888889E+14)
> 015- float(8.88888914608E+14)
>
> $ cat ../ext/mysqli/tests/011.diff
> 011+ float(2345.6)
> 011- float(2345.60009766)
>
> $ cat ../ext/mysqli/tests/012.diff
> 011+ float(2.6)
> 011- float(2.59999990463)[dmitry@tpl2 CGI-DEBUG]$
>
--
Xinchen Hui
@Laruence
http://www.laruence.com/