Fwd: Broken tests

Hi, It seems like the source of the problem is commit c044164a authored by Keyur, I caught the problem because the behavior is different in DEBUG and RELEASE builds. However, I think the behavior introduced by that patch may be wrong. At least it produces different results in comparison to libmysql. Andrey, please made a decision. Thanks. Dmitry. ---------- Forwarded message ---------- From: Dmitry Stogov <dmitry@zend.com> Date: Fri, Dec 26, 2014 at 5:18 PM Subject: Broken tests To: Xinchen Hui <xinchen.h@zend.com> Cc: keyur_govande@yahoo.com, "php-cvs@lists.php.net" <php-cvs@lists.php.net> Hi Xinchen, The commit c2a047cf99f3d020bab12701e8dafed7424673bf made few tests to start fail on 32-bit DEBUG build. The same tests seems to work in RELEASE build. Are you sure these the are changed in a proper way? For me it looks like something was broken in code, and then tests were adjusted for wrong new behaviour. Please, find the source of the problem. Thanks. Dmitry. > mysqli fetch float values [ext/mysqli/tests/010.phpt] > mysqli fetch mixed values [ext/mysqli/tests/011.phpt] > mysqli fetch mixed values 2 [ext/mysqli/tests/012.phpt] $ cat ../ext/mysqli/tests/010.diff 003+ float(3.141593) 003- float(3.14159274101) 005+ float(-1.0E-6) 005- float(-9.99999997475E-7) 009+ float(1.0E+12) 009- float(999999995904) 011+ float(0.5646425) 011- float(0.564642488956) 015+ float(8.888889E+14) 015- float(8.88888914608E+14) $ cat ../ext/mysqli/tests/011.diff 011+ float(2345.6) 011- float(2345.60009766) $ cat ../ext/mysqli/tests/012.diff 011+ float(2.6) 011- float(2.59999990463)[dmitry@tpl2 CGI-DEBUG]$