Re: cvs: php4 /ext/msession msession.c

On Saturday 22 December 2001 04:42 pm, Sean R. Bright wrote: > Hello, > > > -----Original Message----- > > From: mlwmohawk [mailto:mlwmohawk@mohawksoft.com] > > Sent: Saturday, December 22, 2001 4:10 PM > > To: Hartmut Holzgraefe > > Cc: php-cvs@lists.php.net > > Subject: Re: [PHP-CVS] cvs: php4 /ext/msession msession.c > > > > ... > > > > With a little practice the "Hungarian" notation is VERY > > usefull practice. > > Again, I do not wish to sell you on Hungarian notation, I > > just wish you to > > keep your personal tastes to your code and I'll keep mine to my own. > > > > When I edit the code of others, I try to understand their > > naming, their > > style, and their format. I try to make any mods that I would > > make fit in. It > > is a matter of professional respect. > > Well, more than one person has write access to the CVS repository. In my > oppinion, once you have committed your code, it is no longer "yours." it > is the project's. I think that you should respect the rest of us and > comply with the coding standards that the majority of the PHP code is > written in. I checked the other extensions, there are many varying styles. > Although you may be the primary maintainer, there is going > to come a day when someone besides you takes a look at the code and makes > a change or two. You should get used to that and accept it. If you > don't want other people scrutinizing your code and making changes to > create uniformity in the code, the don't contribute code. Simple > solution. I do not mind people looking over my code, I don't mind people adding features they wish to use, I don't mind people using my code. I disagree with the assertion that people should be reformating other people's extensions. Hey, I contributed msession because I thought it was something that PHP could really use. I would like to keep "my" extension in PHP, and I am responsible with it. I don't check in known bugs, I always ensure I can compile it, and I make notes about oddities if there are any. In all rational measures, I think I have contributed a usable module. It may not be perfect, it could be a little more "zend" friendly, but on the whole it works and works pretty well. If you want to tell me you don't want my extension because you don't like the way I format my brackets, and (oh my god) I have the audacity to want to keep my source formatted as I originally wrote it, so I can read it. You are nuts. Way to promote open source dude! > > Open source is a chaotic environment. If you are intolerant > > of the different > > styles of others, you will find that people will find it more > > trouble than it > > is worth to contribute. BTW, mine is not the only extension > > that brackets > > code with the opening bracket on a new line. At least mine is > > consistent. > > I think that "when you write code that goes into the core of PHP or > one of its standard modules, please maintain the K&R style" is the > operative phrase. The "TRUE" K&R style does not even compile with a modern ANSI C compiler. int fin(var) int var; { } > > Plenty of open source projects will not accept code unless it is > in their format. The Apache group is a perfect example of this. I > don't believe that PHP should be any different. I can't believe I am having this conversation. I am getting to old to deal with this non-sense.