Re: cvs: php4 /ext/msession msession.c

Sterling Hughes wrote: > > > Hello, > > > > > -----Original Message----- > > > From: mlwmohawk [mailto:mlwmohawk@mohawksoft.com] > > > Sent: Saturday, December 22, 2001 4:10 PM > > > To: Hartmut Holzgraefe > > > Cc: php-cvs@lists.php.net > > > Subject: Re: [PHP-CVS] cvs: php4 /ext/msession msession.c > > > > > > ... > > > > > > With a little practice the "Hungarian" notation is VERY > > > usefull practice. > > > Again, I do not wish to sell you on Hungarian notation, I > > > just wish you to > > > keep your personal tastes to your code and I'll keep mine to my own. > > > > > > When I edit the code of others, I try to understand their > > > naming, their > > > style, and their format. I try to make any mods that I would > > > make fit in. It > > > is a matter of professional respect. > > > > > > > Well, more than one person has write access to the CVS repository. In my > > oppinion, once you have committed your code, it is no longer "yours." It > > is the project's. I think that you should respect the rest of us and > > comply with the coding standards that the majority of the PHP code is > > written in. Although you may be the primary maintainer, there is going > > to come a day when someone besides you takes a look at the code and makes > > a change or two. You should get used to that and accept it. If you > > don't want other people scrutinizing your code and making changes to > > create uniformity in the code, the don't contribute code. Simple > > solution. > > > I respectfully disagree -- within PHP there are two types of code, > extension code and core code. If you commit code to PHP's core, > then yes, *expect* it to be changed to fit along with the style of > PHP. That's fine, I'm not going to stop anyone from reformatting > that code. Extensions are quite near self-contained programs, and > if an author/maintainer prefers a certain style for his code, that's > his perogative, because chances are he's going to be do 90-95% of > the work on that file (at least), especially with the msession code, > which > > a) isn't that big > b) isn't (yet) that widely implemented > > While I don't think he should've been as forceful with the note > (discussed via pm), as he said he was tootin' mad (I love that > phrase :)... An extension author should still have the right to > maintain a certain style for their code, simply because, they're the > ones who get annoyed by, errm, reports from, users and again, > they're the ones who maintain the code. AMEN! - Stig