Re: com php-src: Change E_ERROR and some E_WARNING to E_RECOVERABLE_ERROR.: ext/session/mod_user.c ext/session/mod_user_class.c ext/session/session.c
ext/session/tests/bug60860.phpt ext/session/tests/bug66481.phpt ext/session/tests/bug67972.phpt
| From: | Yasuo Ohgaki | Date: | Tue, 21 Jul 2015 06:23:57 +0000 |
| Subject: | Re: com php-src: Change E_ERROR and some E_WARNING to E_RECOVERABLE_ERROR.: ext/session/mod_user.c ext/session/mod_user_class.c ext/session/session.c ext/session/tests/bug60860.phpt ext/session/tests/bug66481.phpt ext/session/tests/bug67972.phpt |
||
| References: | 1 | Groups: | php.cvs php.internals |
| Request: | Send a blank email to php-cvs+get-88081@lists.php.net to get a copy of this message | ||
Hi Anatol,
On Tue, Jul 21, 2015 at 3:06 PM, Anatol Belski <anatol.php@belski.net>
wrote:
> Changing E_ERROR to E_RECOVERABLE_ERROR is probably ok where it is safe,
> but changing E_WARNING to E_RECOVERABLE_ERROR is a BC break.
I agree it's BC.
E_ERROR does not give users a chance for graceful script termination and
E_WARNING is
used instead.
This is the only reason why E_WARNING is used before. However, users may
continue
execution with the default setting. I think it's not good to continue with
fatal setting errors,
but I don't mind changing these errors back to E_WARNING.
It's your call.
Regards,
--
Yasuo Ohgaki
yohgaki@ohgaki.net