RE: [PHP-CVS] com php-src: Change E_ERROR and some E_WARNING to E_RECOVERABLE_ERROR.: ext/session/mod_user.c ext/session/mod_user_class.c
ext/session/session.c ext/session/tests/bug60860.phpt ext/session/tests/bug66481.phpt ext/session/tests/bug67972.phpt
| From: | Anatol Belski | Date: | Tue, 21 Jul 2015 09:25:12 +0000 |
| Subject: | RE: [PHP-CVS] com php-src: Change E_ERROR and some E_WARNING to E_RECOVERABLE_ERROR.: ext/session/mod_user.c ext/session/mod_user_class.c ext/session/session.c ext/session/tests/bug60860.phpt ext/session/tests/bug66481.phpt ext/session/tests/bug67972.phpt |
||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-88091@lists.php.net to get a copy of this message | ||
Hi,
> -----Original Message-----
> From: Nikita Popov [mailto:nikita.ppv@gmail.com]
> Sent: Tuesday, July 21, 2015 10:16 AM
> To: Yasuo Ohgaki <yohgaki@php.net>
> Cc: php-cvs@lists.php.net
> Subject: Re: [PHP-CVS] com php-src: Change E_ERROR and some E_WARNING
> to E_RECOVERABLE_ERROR.: ext/session/mod_user.c
> ext/session/mod_user_class.c ext/session/session.c
> ext/session/tests/bug60860.phpt ext/session/tests/bug66481.phpt
> ext/session/tests/bug67972.phpt
>
> On Tue, Jul 21, 2015 at 5:59 AM, Yasuo Ohgaki <yohgaki@php.net> wrote:
>
> > Commit: ad4533fdbabcc3e545277e30023b2fdce16297a0
> > Author: Yasuo Ohgaki <yohgaki@php.net> Tue, 21 Jul 2015
> > 12:59:23 +0900
> > Parents: 22767a48a7bd060f3397713dfe5f2a5581496097
> > Branches: master
> >
> > Link:
> >
> > http://git.php.net/?p=php-src.git;a=commitdiff;h=ad4533fdbabcc3e545277
> > e30023b2fdce16297a0
> >
> > Log:
> > Change E_ERROR and some E_WARNING to E_RECOVERABLE_ERROR.
> >
> > Changed paths:
> > M ext/session/mod_user.c
> > M ext/session/mod_user_class.c
> > M ext/session/session.c
> > M ext/session/tests/bug60860.phpt
> > M ext/session/tests/bug66481.phpt
> > M ext/session/tests/bug67972.phpt
> > M ext/session/tests/session_module_name_variation3.phpt
> > M ext/session/tests/session_name_error.phpt
> > M ext/session/tests/session_name_variation1.phpt
> > M ext/session/tests/session_save_path_variation4.phpt
> > M ext/session/tests/session_set_save_handler_class_014.phpt
> > M ext/session/tests/session_set_save_handler_error3.phpt
> > M ext/session/tests/session_set_save_handler_sid_002.phpt
> >
>
> Yasuo,
>
> did you verify that all cases where you changed an E_ERROR to
> E_RECOVERABLE_ERROR can continue to work correctly if the error is ignored?
>
> IF you can, please add a test that shows that each of these errors can be safely
> ignored.
>
I've reverted this part for now as today is the tag day and master looks good, so I would
prefer to avoid cherry picking. Yasuo, please read the E_ERROR to E_RECOVERABLE_ERROR part once the
tests are there.
Thanks.
Anatol