CVS commit guidelines (was: [PHP-CVS] cvs: php4 /ext/dbase dbase.c)

Arrrgh! Nah, not necessary at all. The problem is that there are no guidelines as to what goes into the NEWS file, and a couple of years ago I go shouted at because I did *not* do so, and it was suggested to me that a short concise description of the fix should go there (Changelog has a more elaborate description, NEWS has a short one). See README.CVS-RULES third paragraph item #2. Examples at the bottom of the file sugget I do exactly what I did too. In fact, since this is brought up I have a couple of questions to the rest of the team: 1. What should be MFH'ed? Trivial fixes? Important fixes? How do I decide what to MFH and what not? And, if a fix should be MFH'ed, then how do I find which branch is currently used for that? Is it still 4_0_7? 2. What fixes should go into NEWS file? 3. What if I have a fix for a bug that is already assigned to someone else? Is it ethical to send them a fix, apply it yourself, or should I wait until they do it? I am sure people who contribute patches occasionally have similar questions.. It would be neat if we could have answers to the questions above, and put them, say, into README.CVS-RULES, or something like that. Happy New Year to you all! Vlad ----- Original Message ----- From: Markus Fischer To: Vlad Krupin Sent: Mon, 31 Dec 2001 12:17:31 +0100 Subject: Re: [PHP-CVS] cvs: php4 /ext/dbase dbase.c On Mon, Dec 31, 2001 at 10:23:30AM -0000, Vlad Krupin wrote : > vlad Mon Dec 31 05:23:30 2001 EDT > > Modified files: > /php4/ext/dbase dbase.c > Log: > Verified and fixed bug 6852 #2. Now memo fields are 10 butes long, not 9. > That does not seem to affect how the code works except when creating a new > structure, in which case 'M' fields used to get created with size 9. > @Fixed bug 6852 #2. Mem fields are now 10 bytesin size, not 9. (Vlad) Is a NEWS entry really necessary for every fix you apply? If so, this would have lead to at least ten or so entries for domxml for me.. IMHO, after you apply a series of fixes just note you fixed several bugs and list the bug reports # if you want to. -- Please always Cc to me when replying to me on the lists. ________________________________________ Re-thinking the Web on a SinglePage(TM) http://www.echospace.com