Re: cvs: php4 /ext/sockets sockets.c
| From: | Markus Fischer | Date: | Tue, 08 Jan 2002 07:58:17 +0000 |
| Subject: | Re: cvs: php4 /ext/sockets sockets.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-8978@lists.php.net to get a copy of this message | ||
On Tue, Jan 08, 2002 at 06:06:58AM -0000, Sterling Hughes wrote :
> sterling Tue Jan 8 01:06:58 2002 EDT
>
> Modified files:
> /php4/ext/sockets sockets.c
> Log:
> Changed proto via Georg Richter's request.
>
>
> Index: php4/ext/sockets/sockets.c
> diff -u php4/ext/sockets/sockets.c:1.85 php4/ext/sockets/sockets.c:1.86
> --- php4/ext/sockets/sockets.c:1.85 Sun Jan 6 06:54:19 2002
> +++ php4/ext/sockets/sockets.c Tue Jan 8 01:06:58 2002
> @@ -19,7 +19,7 @@
> +----------------------------------------------------------------------+
> */
>
> -/* $Id: sockets.c,v 1.85 2002/01/06 11:54:19 venaas Exp $ */
> +/* $Id: sockets.c,v 1.86 2002/01/08 06:06:58 sterling Exp $ */
>
> #ifdef HAVE_CONFIG_H
> #include "config.h"
> @@ -746,7 +746,7 @@
>
> typedef int (*read_func)(int, void *, int);
>
> -/* {{{ proto string socket_read(resource socket, int length [, int type])
> +/* {{{ proto mixed socket_read(resource socket, int length [, int type])
> Reads length bytes from socket */
I thought it was agreed that if the primary return value of a
function is STRING and it just returns FALSE/NULL on errors,
we don't write 'mixed'. We would have to change a lot of
protos then and it would just irritate users (Zak spoke to me
about this lately).