Re: cvs: php4 /ext/domxml config.m4 php_domxml.c php_domxml.h
| From: | derick@php.net | Date: | Tue, 08 Jan 2002 14:17:09 +0000 |
| Subject: | Re: cvs: php4 /ext/domxml config.m4 php_domxml.c php_domxml.h | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-8980@lists.php.net to get a copy of this message | ||
On Tue, 8 Jan 2002, Joao Prado Maia wrote:
> On Tue, 8 Jan 2002, Jaroslaw Kolakowski wrote:
>
> > jarkol Mon Jan 7 19:31:26 2002 EDT
> >
> > Modified files:
> > /php4/ext/domxml config.m4 php_domxml.c php_domxml.h
> > Log:
> > - Added functions: htmldoc(), htmldocfile(), domxml_htmldumpmem().
>
> Just to be really picky, but shouldn't these functions be named
> html_doc(), html_doc_file() and domxml_html_dump_mem() ?
>
> I understand that we already have xmldoc(), xmldocfile(), xmltree() and
> even domxml_dumpmem(), but I still think we should stick we the coding
> standards. It is an extra good thing that this extensions is still
> experimental so we don't have to worry about BC that much.
>
> Am I totally off base here ?
+1 here.
Derick