Re: com php-src: Fixed bug #72735 (Samsung picture thumb not read (zero size)): ext/exif/exif.c ext/exif/tests/bug72735/bug72735.phpt
ext/exif/tests/bug72735/nokia.jpg ext/exif/tests/bug72735/samsung.jpg

Le 03/08/2016 à 10:02, Kalle Sommer Nielsen a écrit : > Commit: 9c8c37854efe843e45228597837fc4b6aac59113 > Author: Kalle Sommer Nielsen <kalle@php.net> Wed, 3 Aug 2016 10:02:22 +0200 > Parents: 1e02e528591544c3e85193531038fa7dcaf3c9ac > Branches: master > > Link: > http://git.php.net/?p=php-src.git;a=commitdiff;h=9c8c37854efe843e45228597837fc4b6aac59113 > > Log: > Fixed bug #72735 (Samsung picture thumb not read (zero size)) > > It seems like there is no maker data for "Samsung", this causes the IDF tag parsing > to fail, and it bails early on, despite there still is valid remaining data in image, such as the > thumbnail data as reported in the bug. > > I used the Exiv2 website as a reference guide for tags that's specific to Samsung's > EXIF data, which should also mean that we will be able to name some of those tags more specifically > now. > > I have chosen again not to commit this to other branches, simply because I'm not 100% sure > on the byte order and offsets for Samsung, I did some research and it seems like there are many > variants, but this (very copy/pasted), entry works for this particular image and does not break any > other tests. This does add a new feature I suppose, while also fixing a bug, but I will leave it to > the other branch RMs to decide on how far down they will want to merge this. Adding more maker data is a good idea, but, BTW, lot are missing (ex: Panasonic) I've tried another approach, for missing maker data (see patch attached to #72735), consider this as a string (null terminated). BTW, this is a regression (it was working before 5.6.24) Can you please give it a try. Remi