Re: com php-src: Fixed bug #72735 (Samsung picture thumb not read (zero size)): ext/exif/exif.c ext/exif/tests/bug72735/bug72735.phpt
ext/exif/tests/bug72735/nokia.jpg ext/exif/tests/bug72735/samsung.jpg
| From: | Remi Collet | Date: | Wed, 03 Aug 2016 08:31:38 +0000 |
| Subject: | Re: com php-src: Fixed bug #72735 (Samsung picture thumb not read (zero size)): ext/exif/exif.c ext/exif/tests/bug72735/bug72735.phpt ext/exif/tests/bug72735/nokia.jpg ext/exif/tests/bug72735/samsung.jpg |
||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-93555@lists.php.net to get a copy of this message | ||
Le 03/08/2016 à 10:27, Kalle Sommer Nielsen a écrit :
> Hi Remi
>
> 2016-08-03 10:16 GMT+02:00 Remi Collet <remi@php.net>:
>> Adding more maker data is a good idea, but, BTW, lot are missing
>> (ex: Panasonic)
>>
>> I've tried another approach, for missing maker data (see patch attached
>> to #72735), consider this as a string (null terminated).
>>
>> BTW, this is a regression (it was working before 5.6.24)
>>
>>
>> Can you please give it a try.
>
> I'm gonna try poke around with it, there seems to be more bug reports
> that could maybe be affected by a similar issue, so fixing this once
> and for all is a good thing.
>
> As for Panasonic, I think we should go and add that too while fixing
> this, Exiv2 have a lot of data for Panasonic as well:
> http://www.exiv2.org/tags-panasonic.html
>
> What I'm thinking is that we can integrate your patch as a fallback,
> so we can continue to read the data after a makernote might not match
> to not confuse the end user, what do you think?
I agree.
Adding more maker data when possible, with a fallback for unknown ones.
Remi