Re: com php-src: Fix #71882: Negative ftruncate() on php://memory exhausts memory: NEWS ext/standard/file.c ext/standard/tests/file/bug71882.phpt
| From: | Matteo Beccati | Date: | Wed, 31 Aug 2016 07:47:44 +0000 |
| Subject: | Re: com php-src: Fix #71882: Negative ftruncate() on php://memory exhausts memory: NEWS ext/standard/file.c ext/standard/tests/file/bug71882.phpt | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-94178@lists.php.net to get a copy of this message | ||
Hi Christoph,
negative size was tested in 4 existing phpt files, that are now failing due to the new warning. That seems a bit of a BC break to me.
https://revive.beccati.com/bamboo/browse/PHP-SRC/latest
In fact ftruncate_variation4.phpt is dubbed "usage variations - truncate file to negative size". This is a reminder that we all should try to run the test suite before pushing changes, at least for the subset of functionalities that are affected by the commit ;)
Cheers
On 30/08/2016 02:05, Christoph Michael Becker wrote:
-- Matteo Beccati Development & Consulting - http://www.beccati.com/Commit: 207dab585aadd9f320976a0895734d7d9ca7b862 Author: Christoph M. Becker <cmbecker69@gmx.de> Tue, 30 Aug 2016 01:53:27 +0200Parents: c7b4cd1a51736b15d095b6b540f17076a0a8433d Branches: PHP-5.6 PHP-7.0 PHP-7.1 masterLink: http://git.php.net/?p=php-src.git;a=commitdiff;h=207dab585aadd9f320976a0895734d7d9ca7b862Log: Fix #71882: Negative ftruncate() on php://memory exhausts memory We must not pass negative sizes to a size_t parameter. Bugs: https://bugs.php.net/71882 Changed paths: M NEWS M ext/standard/file.c A ext/standard/tests/file/bug71882.phpt Diff: diff --git a/NEWS b/NEWS index bc3d279..a05fa84 100644 --- a/NEWS +++ b/NEWS@@ -48,6 +48,8 @@ PHP NEWS. Fixed bug #72278 (getimagesize returning FALSE on valid jpg). (cmb) . Fixed bug #65550 (get_browser() incorrectly parses entries with "+" sign).(cmb)+ . Fixed bug #71882 (Negative ftruncate() on php://memory exhausts memory).+ (cmb)- XML: . Fixed bug #72085 (SEGV on unknown address zif_xml_parse). (cmb) diff --git a/ext/standard/file.c b/ext/standard/file.c index d8471ff..d346ed9 100644 --- a/ext/standard/file.c +++ b/ext/standard/file.c @@ -1512,6 +1512,11 @@ PHP_NAMED_FUNCTION(php_if_ftruncate) RETURN_FALSE; } + if (size < 0) { + php_error_docref(NULL TSRMLS_CC, E_WARNING, "Negative size is not supported"); + RETURN_FALSE; + } + PHP_STREAM_TO_ZVAL(stream, &fp); if (!php_stream_truncate_supported(stream)) { diff --git a/ext/standard/tests/file/bug71882.phpt b/ext/standard/tests/file/bug71882.phpt new file mode 100644 index 0000000..ae0137b --- /dev/null +++ b/ext/standard/tests/file/bug71882.phpt @@ -0,0 +1,11 @@ +--TEST-- +Bug #71882 (Negative ftruncate() on php://memory exhausts memory) +--FILE-- +<?php +$fd = fopen("php://memory", "w+"); +ftruncate($fd, -1); +?> +==DONE== +--EXPECTF-- +Warning: ftruncate(): Negative size is not supported in %s%ebug71882.php on line %d +==DONE==