Re: com php-src: Fix #71882: Negative ftruncate() on php://memory exhausts memory: NEWS ext/standard/file.c ext/standard/tests/file/bug71882.phpt

From: Date: Wed, 31 Aug 2016 11:16:32 +0000
Subject: Re: com php-src: Fix #71882: Negative ftruncate() on php://memory exhausts memory: NEWS ext/standard/file.c ext/standard/tests/file/bug71882.phpt
References: 1 2 3 4 5 6  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-94188@lists.php.net to get a copy of this message
On 31.08.2016 at 13:05, Anatol Belski wrote: > >> -----Original Message----- >> From: Christoph M. Becker [mailto:cmbecker69@gmx.de] >> Sent: Wednesday, August 31, 2016 12:30 PM >> To: Anatol Belski <anatol.php@belski.net>; 'Matteo Beccati' >> <php@beccati.com>; php-cvs@lists.php.net >> Cc: 'Ferenc Kovacs' <tyrael@php.net>; 'Davey Shafik' >> <davey@php.net> >> Subject: Re: [PHP-CVS] com php-src: Fix #71882: Negative ftruncate() on >> php://memory exhausts memory: NEWS ext/standard/file.c >> ext/standard/tests/file/bug71882.phpt >> >> My suggestion is: >> >> if (size < 0) { >> /* php_error_docref(NULL TSRMLS_CC, E_WARNING, "Negative size is not >> supported"); */ >> RETURN_FALSE; >> } >> >> And to uncomment the php_error_docref() call for master (maybe also 7.1). > > ACK. Probably 7.1+ can live with the warning then, doesn't sound like biggie. It's an > error case, and the C runtime warning will be delivered later down the function anyway, say with > plain files. Fine. I'm going to commit this modification including fixes for the tests. >> Yes, you're right. It would be nice, though, if an automatic mail could be sent to >> the committer in case of failure. >> > It sends now a notification on IRC. But sometime that fails, too :) Thanks. I'll probably should join IRC. :-) -- Christoph M. Becker

« previous php.cvs (#94188) next »