Re: com php-src: avoid strlen: ext/intl/locale/locale_methods.c
| From: | Kalle Sommer Nielsen | Date: | Wed, 12 Oct 2016 15:06:45 +0000 |
| Subject: | Re: com php-src: avoid strlen: ext/intl/locale/locale_methods.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-94952@lists.php.net to get a copy of this message | ||
Hi Anatol
2016-10-12 13:28 GMT+02:00 Anatol Belski <ab@php.net>:
> Commit: aaa5d07365b54f35ba3b5024492450f3d2fe4ee5
> Author: Anatol Belski <ab@php.net> Wed, 12 Oct 2016 13:28:23 +0200
> Parents: b26b02b2df95eaa647ea3f4e7b42bd11eea4ed2c
> Branches: PHP-7.0 PHP-7.1 master
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=aaa5d07365b54f35ba3b5024492450f3d2fe4ee5
>
> Log:
> avoid strlen
I thought about this too when I saw the commit last night, but
loc_name_len is not updated if the default locale is returned, what if
that value exceeds INTL_MAX_LOCALE_LEN? Not likely, but still possible
I guess?
--
regards,
Kalle Sommer Nielsen
kalle@php.net