RE: [PHP-CVS] com php-src: avoid strlen: ext/intl/locale/locale_methods.c
| From: | Anatol Belski | Date: | Wed, 12 Oct 2016 19:08:30 +0000 |
| Subject: | RE: [PHP-CVS] com php-src: avoid strlen: ext/intl/locale/locale_methods.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-94967@lists.php.net to get a copy of this message | ||
Hi Kalle,
> -----Original Message-----
> From: kalle.php@gmail.com [mailto:kalle.php@gmail.com] On Behalf Of Kalle
> Sommer Nielsen
> Sent: Wednesday, October 12, 2016 5:07 PM
> To: Anatol Belski <ab@php.net>
> Cc: php-cvs@lists.php.net
> Subject: Re: [PHP-CVS] com php-src: avoid strlen:
> ext/intl/locale/locale_methods.c
>
> Hi Anatol
>
> 2016-10-12 13:28 GMT+02:00 Anatol Belski <ab@php.net>:
> > Commit: aaa5d07365b54f35ba3b5024492450f3d2fe4ee5
> > Author: Anatol Belski <ab@php.net> Wed, 12 Oct 2016 13:28:23 +0200
> > Parents: b26b02b2df95eaa647ea3f4e7b42bd11eea4ed2c
> > Branches: PHP-7.0 PHP-7.1 master
> >
> > Link: http://git.php.net/?p=php-
> src.git;a=commitdiff;h=aaa5d07365b54f35ba3b5024492450f3d2fe4ee5
> >
> > Log:
> > avoid strlen
>
> I thought about this too when I saw the commit last night, but loc_name_len is
> not updated if the default locale is returned, what if that value exceeds
> INTL_MAX_LOCALE_LEN? Not likely, but still possible I guess?
>
Yeah, fixed in d46673d9ce480a241528f4f4de733c113331ceb6.
Thanks for the hint.
Anatol