Re: com php-src: Add hash_hkdf(): NEWS UPGRADING ext/hash/hash.c ext/hash/php_hash.h ext/hash/tests/hash_hkdf_basic.phpt
ext/hash/tests/hash_hkdf_edges.phpt ext/hash/tests/hash_hkdf_error.phpt ext/hash/tests/hash_hkdf_rfc5869.phpt

From: Date: Mon, 16 Jan 2017 00:47:00 +0000
Subject: Re: com php-src: Add hash_hkdf(): NEWS UPGRADING ext/hash/hash.c ext/hash/php_hash.h ext/hash/tests/hash_hkdf_basic.phpt
ext/hash/tests/hash_hkdf_edges.phpt ext/hash/tests/hash_hkdf_error.phpt ext/hash/tests/hash_hkdf_rfc5869.phpt
References: 1 2 3  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-96738@lists.php.net to get a copy of this message
Hi Nikita, On Mon, Jan 16, 2017 at 4:09 AM, Nikita Popov <nikita.ppv@gmail.com> wrote: > To clarify, are you suggesting to swap the info and salt arguments? > There is a thread about HKDF on internals. > I take your mail as "there wasn't discussion about salt". I'll post mail to internals. Making salt a first optional parameter is better. Making salt a required parameter is the best. (No salt for null and default static(known) random salt if empty string) IMHO Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net

« previous php.cvs (#96738) next »